Torch version 2.7.0 update#1552
Conversation
Signed-off-by: yes <shailesh.tanwar@intel.com>
Signed-off-by: yes <shailesh.tanwar@intel.com>
Signed-off-by: yes <shailesh.tanwar@intel.com>
|
@tanwarsh can you elaborate on why the pinning of |
Signed-off-by: yes <shailesh.tanwar@intel.com>
Signed-off-by: yes <shailesh.tanwar@intel.com>
There was a problem hiding this comment.
+1 on @psfoley's concern. I am not in favor of pinning pip. If bumping torch does not solve this problem, might as well not 'fix' this in the current way right now.
Of all packages, pip is seen as an inert package in and of itself. I recommend revisiting this based on user feedback/issues being raised.
|
We can't rely on users to use a specific pip version. My recommendation would be to add @kta-intel's patch directly before the PyTorchDataLoader import; that way we maintain compatibility across all PyTorch and pip versions. No user modifications are required: Tested this and confirmed working with PyTorch 2.6.0 and pip 25.0.1, as well as PyTorch 2.4.1 and pip 24.1.2 As an aside, I was not able to install Pytorch 2.7 with Python 3.10. Anyone else facing this issue? |
Signed-off-by: yes <shailesh.tanwar@intel.com>
Signed-off-by: yes <shailesh.tanwar@intel.com>
Signed-off-by: yes <shailesh.tanwar@intel.com>
@psfoley, I have added the patch. I am able to install Pytorch 2.7 with Python 3.10. |
MasterSkepticista
left a comment
There was a problem hiding this comment.
Request placing a warning before the patch is applied in code to notify the development team and users. Else it may lead to inadvertent silent errors should this be fixed by PyTorch team in the future.
teoparvanov
left a comment
There was a problem hiding this comment.
Approved, but please wait for the PQ pipeline to be stabilized before merging into develop:
https://github.com/securefederatedai/openfl/actions/workflows/pq_pipeline.yml
Signed-off-by: yes <shailesh.tanwar@intel.com>
@teoparvanov, for version >=2.5.0 the file are no longer generated by PyTorch in tmp folder and hence the pipeline was failing. Added code to omit file check in tmp folder. |
* torch version update Signed-off-by: yes <shailesh.tanwar@intel.com> * pip version update Signed-off-by: yes <shailesh.tanwar@intel.com> * pip version update Signed-off-by: yes <shailesh.tanwar@intel.com> * update ti 2.7.0 Signed-off-by: yes <shailesh.tanwar@intel.com> * pip version pinned Signed-off-by: yes <shailesh.tanwar@intel.com> * code changes Signed-off-by: yes <shailesh.tanwar@intel.com> * code format Signed-off-by: yes <shailesh.tanwar@intel.com> * omit pytorch generated files Signed-off-by: yes <shailesh.tanwar@intel.com> --------- Signed-off-by: yes <shailesh.tanwar@intel.com> Co-authored-by: teoparvanov <teodor.parvanov@intel.com> Signed-off-by: Chaurasiya, Payal <payal.chaurasiya@intel.com>
* torch version update Signed-off-by: yes <shailesh.tanwar@intel.com> * pip version update Signed-off-by: yes <shailesh.tanwar@intel.com> * pip version update Signed-off-by: yes <shailesh.tanwar@intel.com> * update ti 2.7.0 Signed-off-by: yes <shailesh.tanwar@intel.com> * pip version pinned Signed-off-by: yes <shailesh.tanwar@intel.com> * code changes Signed-off-by: yes <shailesh.tanwar@intel.com> * code format Signed-off-by: yes <shailesh.tanwar@intel.com> * omit pytorch generated files Signed-off-by: yes <shailesh.tanwar@intel.com> --------- Signed-off-by: yes <shailesh.tanwar@intel.com> Co-authored-by: teoparvanov <teodor.parvanov@intel.com> Signed-off-by: Tayfun Ceylan <tayfun.ceylan>
Summary
Pytorch version updated to 2.7.0.
torchvision version updated to 0.22.0.
pinned pip version to 24.1.2 to avoid error Type parameter +RV without a default follows type parameter with a default
Type of Change (Mandatory)
Specify the type of change being made.
Description (Mandatory)
Updated torch version to fix https://github.com/securefederatedai/openfl/security/dependabot/1979 to https://github.com/securefederatedai/openfl/security/dependabot/1999